Skip to content

[UR][L0] Address issue with unnecessary event for barrier #17841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[UR][L0] Address issue with unnecessary event for barrier #17841

wants to merge 1 commit into from

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Apr 4, 2025

  • Remove creation of an event that is not used in the barrier as a signal event and simply is added to the cache. This leaks an event resource when this is called. The event creation in this case has been removed.

@nrspruit nrspruit requested a review from a team as a code owner April 4, 2025 01:03
@kbenzie kbenzie requested review from a team and removed request for a team April 4, 2025 09:21
@nrspruit nrspruit closed this Apr 4, 2025
@nrspruit
Copy link
Contributor Author

nrspruit commented Apr 4, 2025

This apparently is an event created to be reused after this call. Without this event, there is a queue and event that is not released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igchor igchor igchor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrspruit @igchor